Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Shapes/Primitives! #13

Open
cqann opened this issue Jul 29, 2020 · 4 comments
Open

More Shapes/Primitives! #13

cqann opened this issue Jul 29, 2020 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@cqann
Copy link
Collaborator

cqann commented Jul 29, 2020

I suggest that more shapes should be added to PyPen!
More specifically these primitives should be added:

  • Triangle
  • Line
  • Custom Shape (with begin_shape and end_shape)
  • potentially square, equilateral_triangle, point (just a pixel) and curve
@cqann cqann added the enhancement New feature or request label Jul 29, 2020
@cqann cqann added this to the 1.0.0 milestone Jul 29, 2020
@EriKWDev
Copy link
Contributor

N-gon, centered_rectangle and centered_square :3 (if we don't implement them in a different way)

@cqann
Copy link
Collaborator Author

cqann commented Jul 29, 2020

I agree that shapes such as rectangles should be able to be centered, but I don't believe that they should have their own primitives. Instead I'm suggesting that we maybe implement a rectangle_mode, either a function or variable. This would contain info which would be checked in the rectangle primitive, and translation would then be carried out there.

@EriKWDev
Copy link
Contributor

EriKWDev commented Jul 31, 2020

Different modes seems like a good idea :) settings.rectangle_mode = "normal" | "center"/"middle" could do that.
We should probably, speaking of modes, also have settings.angle_mode = "degrees" | "radians"

@EriKWDev
Copy link
Contributor

Instead I'm suggesting that we maybe implement a rectangle_mode, either a function or variable

see #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants