Add args
argument to REPLWrapper
& spawn()
to mimic pty_spawn
#281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originates from the issue related to my recent PR to
octave_kernel
[Re: space in the octave executable path in Windows].This PR contains two commits:
e800dca: This commit adds
args
list argument to theREPLWrapper
constructor so it can be passed down tospawn
. A test method has also been added totest_replwrap.py
.303f2fd:
pty_spawn
and non-pty_spawn
codepaths currently handlescommand
andargs
differently. This commit makes the non-pty
path to be comparable to thepty_spawn
implementation. That is,command
is only split only ifargs
is not provided.These two mechanisms are essential to allow an octave executable path with spaces to run in Windows. If this PR is accepted, I will create another PR in
octave_kernel
to finish resolving the issue.Thanks