Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Ipython and metakernel magics #206

Open
joequant opened this issue Aug 18, 2020 · 3 comments
Open

Merge Ipython and metakernel magics #206

joequant opened this issue Aug 18, 2020 · 3 comments

Comments

@joequant
Copy link
Contributor

Right now Ipython and metakernel have separate standards for setting up magics, and this leads to maintainability issues. It would be nice if there were a way of writing one set of code that would work for both.

@dsblank
Copy link
Member

dsblank commented Aug 18, 2020

That is true, but I think unavoidable in most circumstances. Metakernel's magics are designed to be language independent, whereas IPython's are baked into a specific language (Python). Having said that, there may be more we can do to fix individual differences. Is there something specific that you are thinking about?

@joequant
Copy link
Contributor Author

The problem is is that the language processing for the magics tends to be the same, and by having two different files, we are running into code forks where fixes for one code base aren't making it into the other.

In the worst case, we can have metakernel and Ipython have two different interface codes that call the same language processing module. Will take a look at what can be done.

@blink1073
Copy link
Contributor

For reference, here is how xeus-python uses the IPython magics directly. However, they are also a Python kernel, as Doug mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants