Doesn't report error status in execute_reply msg

[jayendra13]

Version info

matlab        : 9.5.0.944444 (R2018b)
matlab_kernel : 0.15.1

I am running a matlab code with matlab_kernel having a syntax error, and tracking the messages from the iopub channel.
This is the execute_reply msg from the iopub channel.

{'buffers': [],
 'content': {u'execution_count': 1,
             u'payload': [],
             u'status': u'ok',
             u'user_expressions': {}},
 'header': {u'date': datetime.datetime(2018, 10, 4, 6, 11, 22, 642374, tzinfo=tzutc()),
            u'msg_id': u'1f698f2d-0d99bf43400c21a4a318708d',
            u'msg_type': u'execute_reply',
            u'session': u'94bae730-e12ee227be016e5e947bf704',
            u'username': u'jayendra',
            u'version': u'5.3'},
 'metadata': {u'started': u'2018-10-04T06:11:22.406073Z'},
 'msg_id': u'1f698f2d-0d99bf43400c21a4a318708d',
 'msg_type': u'execute_reply',
 'parent_header': {u'date': datetime.datetime(2018, 10, 4, 6, 11, 16, 937573, tzinfo=tzutc()),
                   u'msg_id': u'e5c2386c-c924e5654ae5e26a59336730',
                   u'msg_type': u'execute_request',
                   u'session': u'3851d47e-5fda30d441f1814fdb335ba5',
                   u'username': u'jayendra',
                   u'version': u'5.3'}}

When matlab encounter the error while executing the code, the status (under the content ) should be error instead of ok.

ref: https://jupyter-client.readthedocs.io/en/stable/messaging.html#request-reply

[blink1073]

Thanks for the report, @jayendra13! I suspect this problem exists in metakernel, which the matlab_kernel is built upon. I don't have the cycles currently to dig into it...

[jayendra13]

Thanks @blink1073 for the prompt response.
This thing is critical to my project, should I re-raise this in metakernel repo ?
or can you give any pointers where should I look for this ?

[blink1073]

I suspect it is here. Yes, please, I think the issue is better suited on that repo.

[jayendra13]

moved here
Calysto/metakernel#175

[jayendra13]

@blink1073 I think this could be issue a issue Calysto/metakernel#175 (comment)

[jayendra13]

@blink1073 I have made some fixes for this, how can submit a PR ?

[blink1073]

Are the fixes here, in metakernel, or both?

[jayendra13]

only here.

[blink1073]

Great! Is this your first time making a PR on Github?

[jayendra13]

oh yes,
I think flow is like fork the repo, do commit there and ask repo maintainer to merge the fork.

[jayendra13]

or you can give me access to push a new branch here ?

[blink1073]

1. Fork the repo
2. Create a new branch for the changes
3. Commit your changes to the branch
4. Push the branch to your origin
5. Open a PR on github
6. I'll review and merge

[blink1073]

This site looks pretty good for an overview: https://services.github.com/on-demand/github-cli/open-pull-request-github

[jayendra13]

Done please review that.
Thanks

[blink1073]

Fixed by #114.