Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating thold from console->data sources allows create thold without validation #691

Open
xmacan opened this issue Aug 19, 2024 · 0 comments

Comments

@xmacan
Copy link
Member

xmacan commented Aug 19, 2024

Create thold with wizard works fine - hi/low values are checked (low is lower then high, ...).

Create threshold from console -> data sources -> click Template name -> doesn't check hi/low (or others) limits.

In thold_validate_save function is exception for this:
/**

  • Only validate thresholds once they are created
  • This is required due to the wizard control on the
  • Thold page.
    */
    if ($type == 'thold' && empty($save['id'])) {
    return true;
    }

it's more complicated than I thought. So far I'm just logging the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant