pacman: Build with PrettyProgressBar #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Naim
force-pushed
the
feat/pacutils-prettyprogressbar
branch
from
897a9fd
to
def37fb
Compare
1Naim
changed the title
1Naim
force-pushed
the
feat/pacutils-prettyprogressbar
branch
from
def37fb
to
032ed7d
Compare
|
we use staging flag for building against staging branch. Currently its the same and doesnt build from staging. Regarding patch the "disabling" of it can be done via commenting it out, because its automatically patched if present in source array |
The pacman PKGBUILD we provide has a patch that enables a unicode progress bar when built with the necessary options. When used with upstream pacutils however, pacconf will print out warnings about "PrettyProgressBar" config option not existing because of the way it parses configs manually. For QoL reasons, I have made a patch to add that config option to pacconf directly so it doesn't complain when used with PrettyProgressBar'ed pacman Signed-off-by: Eric Naim <[email protected]>
Builds pacman with PrettyProgressBar functionality. This option, when enabled, will render the progress bar using specifing unicode characters so it looks "pretty". It is disabled by default for compatibility reasons (some terminals cannot render unicode characters nicely, and not all fonts have those specific unicode characters). I've moved relevant patch to the main source array to facilitate this change. Signed-off-by: Eric Naim <[email protected]>
1Naim
force-pushed
the
feat/pacutils-prettyprogressbar
branch
from
032ed7d
to
fa1f66c
Compare
That's a good point. I also wasn't aware about building from staging part as that wasn't apparent with the current state of the PKGBUILD. I've updated the PR accordingly tho, thanks for the pointers ^^ |
vnepogodin
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds pacman with PrettyProgressBar functionality. This option, when enabled, will render the progress bar using
specifing unicode characters so it looks "pretty". It is disabled by default for compatibility reasons (some terminals
cannot render unicode characters nicely, and not all fonts have those specific unicode characters).
Currently, I have just flipped ``$_staging` to true for easy disabling of the patch, but this may change later.
To complement
PrettyProgressBarenablement in pacman. I have also addedpacutilspackage that addsPrettyProgressBaras a valid config option so it doesn't spam warnings.