Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong extension checking #5

Open
BoyBaykiller opened this issue Mar 1, 2022 · 3 comments
Open

Wrong extension checking #5

BoyBaykiller opened this issue Mar 1, 2022 · 3 comments
Labels
wontfix This will not be worked on

Comments

@BoyBaykiller
Copy link

BoyBaykiller commented Mar 1, 2022

I was trying to run the precompiled binary contained in bin_x86_64_windows. Output:
image

I don't exactly know how hasARBTextureFilterAnisotropic is set here:

enforce(hasARBTextureFilterAnisotropic, "The graphics card does not support ARB_texture_filter_anisotropic");
I do know though that my GPU not only supports OpenGL 4.6 (where anisotropic filtering is core) it also has GL_ARB_texture_filter_anisotropic and GL_EXT_texture_filter_anisotropic.

This project is quite old so if you're not willing to work on it anymore I understand that. If you do, here is what I would suggest:

According to the OpenGL Wiki the correct way to check for a core extensions is to both check for the version which is 4.6 and the presence of the extension which would be GL_ARB_texture_filter_anisotropic. Since GL_EXT_texture_filter_anisotropic is considered to be a ubiquitous extension it would make sense to also check for that - and then use the
corresponding functionality provided by that extension.

@BoyBaykiller BoyBaykiller changed the title Wrong extensions checking Wrong extension checking Mar 1, 2022
@CZDanol
Copy link
Owner

CZDanol commented Mar 1, 2022

Hello,
yes, sorry, this project is no longer maintained. However you can check this out if you're interested: https://github.com/AnotherCraft/ac-releases/releases

@CZDanol CZDanol closed this as completed Mar 1, 2022
@CZDanol CZDanol added the wontfix This will not be worked on label Mar 1, 2022
@CZDanol CZDanol reopened this Mar 1, 2022
@BoyBaykiller
Copy link
Author

Alright cool. The release you provided works!

@CZDanol CZDanol reopened this Mar 1, 2022
@CZDanol
Copy link
Owner

CZDanol commented Mar 1, 2022

I'm keeping this open in case someone fixes it in the code or something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants