Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lexicographical data (lexemes) #100

Open
mormegil-cz opened this issue Jun 6, 2023 · 2 comments
Open

Support lexicographical data (lexemes) #100

mormegil-cz opened this issue Jun 6, 2023 · 2 comments
Labels
Feature Request grab and go non-blocking and specific tasks welcoming contribution from anyone Wikibase
Milestone

Comments

@mormegil-cz
Copy link
Contributor

WikiClientLibrary currently misses BuiltInDataTypes for Wikidata’s lexicographical data.

As far as I can tell, basically three new definitions of the data types, plus a more general implementation of EntityIdFromJson+EntityIdToJson is needed.

See my quick-and-dirty implementation of those (also including a copy-paste of the inaccessible internal sealed DelegatePropertyType from the library) which seems to work fine.

@CXuesong
Copy link
Owner

Thanks for pointing this out! Regretfully I may not have enough time at the moment 🌚 I'll look into this when I'm available (might be much later).

Just in case you have some time available during the next few months, probably you can propose a PR so that you can at least have something from WCL library without any hacking.

@CXuesong CXuesong added the grab and go non-blocking and specific tasks welcoming contribution from anyone label Jun 16, 2023
@CXuesong
Copy link
Owner

Okay I've checked the documentation and realized this is a concept like Item / Property / Entity. Then I guess we'd better wait for a while until I have some more time to look into it.

@CXuesong CXuesong modified the milestones: v0.8.0, v0.8.x May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request grab and go non-blocking and specific tasks welcoming contribution from anyone Wikibase
Projects
None yet
Development

No branches or pull requests

2 participants