Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs need to support clipping of lines to border of graph #1

Open
kms15 opened this issue Jul 30, 2011 · 0 comments
Open

Graphs need to support clipping of lines to border of graph #1

kms15 opened this issue Jul 30, 2011 · 0 comments
Assignees

Comments

@kms15
Copy link
Member

kms15 commented Jul 30, 2011

If a path contains a large finite value - say (1, 1e99) - the canvas widget in Firefox will refuse to draw the entire path (including lines that are within the window). Currently the graphing code tries to draw lines this way, and this makes it very difficult to diagnose numerical stability errors, because you can't see the behavior before the equation blows up.

The correct way to fix this is to manually clip the line segment to the four edges of the window; we can't just clip the x or y value. It is possible to have points with extremely large but meaningful screen coordinates (e.g. when manual zoom is added), and a line from 0 to 1e11, 2e11 should still have the correct slope.

@ghost ghost assigned kms15 Jul 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant