Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State that these functions are not vectorised (or vectorise them?) #13

Open
gabrielodom opened this issue Jul 16, 2024 · 0 comments
Open

State that these functions are not vectorised (or vectorise them?) #13

gabrielodom opened this issue Jul 16, 2024 · 0 comments
Assignees
@gabrielodom
Labels
build request add core functionality documentation Improvements or additions to documentation

Comments

@gabrielodom
Copy link
Contributor

Here is an example:

CTNote::count_matches(use_pattern = c("-----", "o-o--"), match_is = "-")

This returns the (somewhat confusing) error

Error in if (pattern_trim_length == 0) { : the condition has length > 1

We need to

  1. vectorise all the functions, or
  2. add a better error message and function documentation AND add calls to dplyr::rowwise() in the examples
@gabrielodom gabrielodom added documentation Improvements or additions to documentation build request add core functionality labels Jul 16, 2024
@gabrielodom gabrielodom self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielodom gabrielodom

Labels
build request add core functionality documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabrielodom