Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing hash_table.h #68

Open
Quincunx271 opened this issue Apr 13, 2020 · 1 comment
Open

Removing hash_table.h #68

Quincunx271 opened this issue Apr 13, 2020 · 1 comment

Comments

@Quincunx271
Copy link
Member

hash_table.h is a rather large file (900 lines of code). Only one of the types, BinHashTable, is used, and only in one place (enumerator.h / enumerator.cpp). Together with hist_table.h, this appears to form the history hash table.

What data structure is BinHashTable? If we can understand it well enough, we may be able to replace it with llvm or standard library data structures, removing quite a bit of otherwise unused code.

@kerbowa
Copy link
Member

kerbowa commented Apr 14, 2020

It's an implementation of a hash table. We should be able to replace it. This was on my todo list, hopefully I get the time to work on it.

DenseMap or something should work http://llvm.org/docs/ProgrammersManual.html#map-like-containers-std-map-densemap-etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants