Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After #148, unnecessary reset work is done for the SLIL LB if it has not been computed before. #173

Open
Quincunx271 opened this issue Oct 21, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Quincunx271
Copy link
Member

Quincunx271 commented Oct 21, 2021

#148 requires some work to reset the SLIL LB, because graph transformations can change the LB and thus the LB must be recomputed. Without a reset, the recomputation will fail. However, for the first computation of the SLIL LB, this is unnecessary reset work.


Seems like we may want to use a state variable / different control flow to only reset when necessary. In other words, if we haven't computed the SLILLB before, then this is just wasted cycles.

Originally posted by @jrbyrnes in #148 (comment)

@jrbyrnes
Copy link
Contributor

Responding to your PR reply --

This issue seems at least somewhat related to #174 and can probably be handled in the same PR (after you've merged in).

@Quincunx271 Quincunx271 added the enhancement New feature or request label Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants