-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable servers #312
Configurable servers #312
Conversation
Pull Request Test Coverage Report for Build 6352852909
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how it relates to bird-house/birdhouse-deploy#14 for the WPS response URLs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice now that both Thredds and Geoserver are configurable. Simply keep the backward-compat with the old public configGEO_URL
please.
@huard Builds appear to be failing due to SDBA-related changes. Could it be the latest EDIT: Nvm, this is coming from the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should always try to minimize breaking changes that are backward incompatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI @fmigneault
Changes
RAVENPY_THREDDS_URL
: URL to the THREDDS-hosted climate data service. Defaults tohttps://pavics.ouranos.ca/twitcher/ows/proxy/thredds
.RAVENPY_GEOSERVER_URL
: URL to the GeoServer-hosted vector/raster data. Defaults tohttps://pavics.ouranos.ca/geoserver
.GEO_URL
is still valid for legacy purposes._determine_upstream_ids
function underravenpy.utilities.geoserver
was a direct copy ofdetermine_upstream_ids
found inravenpy.utilities.geo
and has been removed.get_CASPAR_dataset
andget_ECCC_dataset
functions now accept athredds
and adirectory
in their call signatures for specifying file location.xarray
below2023.09.0
until xclim addresses compatibility issues (will be fixed in0.46.0
).Relevant discussion:
bird-house/birdhouse-deploy#14