From fc5d3166bd5f0efcc72021b96eaec0323d1fa508 Mon Sep 17 00:00:00 2001 From: Stephanie Reinders Date: Wed, 4 Sep 2024 09:22:17 -0500 Subject: [PATCH] Updated cran-comments and NEWS with notes about patch changes --- NEWS.md | 6 ++++++ R/app.R | 4 ++-- R/case_known.R | 2 +- R/case_maindir.R | 2 +- R/case_qd.R | 2 +- R/case_report.R | 2 +- R/current_image.R | 2 +- R/data.R | 2 +- R/demo_preview.R | 2 +- R/inner.R | 2 +- R/server_utils.R | 2 +- R/ui_utils.R | 2 +- R/utils-pipe.R | 18 ------------------ cran-comments.md | 18 +++++++++++------- man/handwriterApp.Rd | 2 +- 15 files changed, 30 insertions(+), 38 deletions(-) diff --git a/NEWS.md b/NEWS.md index 4a7101e..3f8e3c4 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,11 @@ # handwriterApp 1.0.1 +* Changed the title from "Shiny App for Handwriting Analysis in R" to "A 'shiny' Application for Handwriting Analysis" + +* Placed package names in single undirected quotes, and changed directed quotation marks to undirected quotes in the description text. + +* Added "\value{No return value, called to launch 'shiny' app}" to the .Rd file for for the exported method handwriterApp(). + # handwriterApp 1.0.0 * Initial CRAN submission. diff --git a/R/app.R b/R/app.R index 21c4fdb..9e5be5c 100644 --- a/R/app.R +++ b/R/app.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # @@ -18,7 +18,7 @@ #' Handwriter Application #' -#' Lauch a Shiny App for 'handwriter'. +#' Lauch a 'shiny' application for 'handwriter'. #' #' @param ... Other arguments passed on to 'onStart', 'options', #' 'uiPattern', or 'enableBookmarking' of 'shiny::shinyApp' diff --git a/R/case_known.R b/R/case_known.R index 641ca61..36ec005 100644 --- a/R/case_known.R +++ b/R/case_known.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/case_maindir.R b/R/case_maindir.R index 7903284..47bbb4f 100644 --- a/R/case_maindir.R +++ b/R/case_maindir.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/case_qd.R b/R/case_qd.R index 10742cd..c443c0b 100644 --- a/R/case_qd.R +++ b/R/case_qd.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/case_report.R b/R/case_report.R index 53e6b22..85c9006 100644 --- a/R/case_report.R +++ b/R/case_report.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/current_image.R b/R/current_image.R index 9d4277f..37e6adc 100644 --- a/R/current_image.R +++ b/R/current_image.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/data.R b/R/data.R index b0f9f0d..7a876fd 100644 --- a/R/data.R +++ b/R/data.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/demo_preview.R b/R/demo_preview.R index 70e81f9..ff91092 100644 --- a/R/demo_preview.R +++ b/R/demo_preview.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/inner.R b/R/inner.R index bc84c79..f9b61be 100644 --- a/R/inner.R +++ b/R/inner.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/server_utils.R b/R/server_utils.R index 039c936..206af57 100644 --- a/R/server_utils.R +++ b/R/server_utils.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/ui_utils.R b/R/ui_utils.R index a67b9d6..1503053 100644 --- a/R/ui_utils.R +++ b/R/ui_utils.R @@ -1,4 +1,4 @@ -# The handwriterApp R package performs writership analysis of handwritten +# The 'handwriterApp' R package performs writership analysis of handwritten # documents. Copyright (C) 2024 Iowa State University of Science and Technology # on behalf of its Center for Statistics and Applications in Forensic Evidence # diff --git a/R/utils-pipe.R b/R/utils-pipe.R index 1040c2c..fd0b1d1 100644 --- a/R/utils-pipe.R +++ b/R/utils-pipe.R @@ -1,21 +1,3 @@ -# The handwriterApp R package performs writership analysis of handwritten -# documents. Copyright (C) 2024 Iowa State University of Science and Technology -# on behalf of its Center for Statistics and Applications in Forensic Evidence -# -# This program is free software: you can redistribute it and/or modify it under -# the terms of the GNU General Public License as published by the Free Software -# Foundation, either version 3 of the License, or (at your option) any later -# version. -# -# This program is distributed in the hope that it will be useful, but WITHOUT -# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS -# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more -# details. -# -# You should have received a copy of the GNU General Public License along with -# this program. If not, see . - - #' Pipe operator #' #' See \code{magrittr::\link[magrittr:pipe]{\%>\%}} for details. diff --git a/cran-comments.md b/cran-comments.md index 1f13a7b..87c168a 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,10 +1,14 @@ -## R CMD check results +## Resubmission +This is a resubmission. In this version I have: -0 errors | 0 warnings | 1 note +* Changed the title from "Shiny App for Handwriting Analysis in R" to "A 'shiny' Application for Handwriting Analysis" + +* Placed package names in single undirected quotes, and changed directed quotation marks to undirected quotes in the description text. + +* Added "\value{No return value, called to launch 'shiny' app}" to the .Rd file for for the exported method handwriterApp(). -checking CRAN incoming feasibility ... [3s/12s] NOTE - Maintainer: ‘Stephanie Reinders ’ - - New submission +* Verified that functions do not write by default or in examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). -* This is a new release \ No newline at end of file +## R CMD check results + +0 errors | 0 warnings | 1 note diff --git a/man/handwriterApp.Rd b/man/handwriterApp.Rd index 764e7d7..7baa5de 100644 --- a/man/handwriterApp.Rd +++ b/man/handwriterApp.Rd @@ -14,7 +14,7 @@ handwriterApp(...) No return value, called to launch 'shiny' app } \description{ -Lauch a Shiny App for 'handwriter'. +Lauch a 'shiny' application for 'handwriter'. } \examples{ ## Only run this example in interactive R sessions