From 1df24c604e5c5f0e0fe762ad261cd1d5f486fac6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20Borgna?= Date: Fri, 11 Oct 2024 16:47:08 +0100 Subject: [PATCH 1/2] ci: Ensure we're using the right py version when testing on CI --- .github/workflows/ci.yml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d0b2a90..0f147be7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,7 +20,10 @@ env: SCCACHE_GHA_ENABLED: "true" RUSTC_WRAPPER: "sccache" # Pinned version for the uv package manager - UV_VERSION: "0.4.18" + UV_VERSION: "0.4.20" + # The highest and lowest supported Python versions, used for testing + PYTHON_HIGHEST: "3.13" + PYTHON_LOWEST: "3.10" jobs: # Check if changes were made to the relevant files. @@ -89,10 +92,10 @@ jobs: with: version: ${{ env.UV_VERSION }} enable-cache: true - - name: Install Python 3.13 - run: uv python install 3.13 + - name: Install Python ${{ env.PYTHON_HIGHEST }} + run: uv python install ${{ env.PYTHON_HIGHEST }} - name: Setup dependencies - run: uv sync --locked + run: uv sync --locked --python ${{ env.PYTHON_HIGHEST }} - name: Type check with mypy run: uv run mypy . - name: Check formatting with ruff @@ -231,10 +234,10 @@ jobs: with: version: ${{ env.UV_VERSION }} enable-cache: true - - name: Install Python 3.10 - run: uv python install 3.10 + - name: Install Python ${{ env.PYTHON_LOWEST }} + run: uv python install ${{ env.PYTHON_LOWEST }} - name: Setup dependencies - run: uv sync --locked + run: uv sync --locked --python ${{ env.PYTHON_LOWEST }} - name: Run python tests with coverage instrumentation run: uv run pytest --cov=./ --cov-report=xml - name: Upload coverage output artifact From 569d023d980846b36b7ed6ec033025130f6a079e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agust=C3=ADn=20Borgna?= Date: Mon, 14 Oct 2024 11:58:43 +0100 Subject: [PATCH 2/2] Downgrade to python 312 --- .github/workflows/ci.yml | 2 +- .github/workflows/python-pure-wheels.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0f147be7..4884b276 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,7 @@ env: # Pinned version for the uv package manager UV_VERSION: "0.4.20" # The highest and lowest supported Python versions, used for testing - PYTHON_HIGHEST: "3.13" + PYTHON_HIGHEST: "3.12" PYTHON_LOWEST: "3.10" jobs: diff --git a/.github/workflows/python-pure-wheels.yml b/.github/workflows/python-pure-wheels.yml index 7f2483da..42262a3a 100644 --- a/.github/workflows/python-pure-wheels.yml +++ b/.github/workflows/python-pure-wheels.yml @@ -53,8 +53,8 @@ jobs: with: version: ${{ env.UV_VERSION }} enable-cache: true - - name: Install Python 3.13 - run: uv python install 3.13 + - name: Install Python 3.12 + run: uv python install 3.12 - name: Build sdist and wheels if: ${{ steps.check-tag.outputs.run == 'true' }}