Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce TASO hashtable size #145

Closed
lmondada opened this issue Sep 28, 2023 · 1 comment
Closed

Reduce TASO hashtable size #145

lmondada opened this issue Sep 28, 2023 · 1 comment
Assignees
Labels
badger-optimiser TASO optimization perf Performance issue

Comments

@lmondada
Copy link
Contributor

lmondada commented Sep 28, 2023

We had a PR that did this (#133 e33fc6a), but had to revert it in #144 as it was hurting optimisation performance.

Done right, it should not have any impact on optimisation.

@aborgna-q aborgna-q added perf Performance issue badger-optimiser TASO optimization labels Sep 29, 2023
@lmondada lmondada self-assigned this Oct 3, 2023
@aborgna-q
Copy link
Collaborator

I'm tempted to close this as wontfix. Hashes are u64s, so even storing 10k hashes takes ~100kB.
We currently only hash circuits small enough to be inserted on the queue, so the # of circuits doesn't grow that quickly.

For example, running the barenco_tof_10 example for 100s the hash table grows to 3k2 circuits, while the peak memory consumption goes up to 390MB.

@aborgna-q aborgna-q closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
badger-optimiser TASO optimization perf Performance issue
Projects
None yet
Development

No branches or pull requests

2 participants