Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rule of zero wherever possible. Add move semantics otherwise. #19

Open
lmondada opened this issue Sep 22, 2021 · 0 comments
Open

Use rule of zero wherever possible. Add move semantics otherwise. #19

lmondada opened this issue Sep 22, 2021 · 0 comments

Comments

@lmondada
Copy link
Contributor

We currently ignore the existence of move semantics in bubble. That might be having an impact on performance (probably hard to quantify though).

With modern C++, most classes should be able to get by without managing any memory themselves. These classes should follow the rule of zero. If specific memory manipulations are necessary, there should be dedicated classes for that purpose and they should follow the rule of five.

Note: I don't know what the status is for the BGL. Copying graph can invalidate references to vertices etc., so one should think of an elegant solution to this problem if we want to follow the rule of 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant