Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internals of qiskit_to_tk conversion further #419

Open
CalMacCQ opened this issue Nov 20, 2024 · 0 comments
Open

Refactor internals of qiskit_to_tk conversion further #419

CalMacCQ opened this issue Nov 20, 2024 · 0 comments
Labels
circuit_conversion Issues and pull requests related to coverting qiskit circuits to pytket and vice versa enhancement New feature or request good first issue Good for newcomers

Comments

@CalMacCQ
Copy link
Contributor

the qiskit_to_tk function uses a somewhat complicated CircuitBuilder.add_qiskit_data method internally.

I think it would be nicer/ more readable if this method was refactored to a pattern match (python match-case) on the optype variable. Theres some special handling of PauliEvolutionGate , UnitaryGate and CU3 gates that complicate things slightly.

Related issue #313
@CalMacCQ CalMacCQ added enhancement New feature or request good first issue Good for newcomers circuit_conversion Issues and pull requests related to coverting qiskit circuits to pytket and vice versa labels Nov 20, 2024
@CalMacCQ CalMacCQ changed the title Improve internals of qiskit_to_tk conversion further Refactor internals of qiskit_to_tk conversion further Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
circuit_conversion Issues and pull requests related to coverting qiskit circuits to pytket and vice versa enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CalMacCQ