Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support diagonal gates in circuit converters #151

Open
CalMacCQ opened this issue Jul 19, 2023 · 1 comment
Open

Support diagonal gates in circuit converters #151

CalMacCQ opened this issue Jul 19, 2023 · 1 comment
Labels
circuit_conversion Issues and pull requests related to coverting qiskit circuits to pytket and vice versa enhancement New feature or request good first issue Good for newcomers

Comments

@CalMacCQ
Copy link
Contributor

CalMacCQ commented Jul 19, 2023 •
edited
Loading

Qiskit have diagonal gates.

These seem to be implemented in the same way as pytket's DiagonalBox. We should be able to support this in the circuit converters.
@CalMacCQ
Copy link
Contributor Author

CalMacCQ commented Sep 28, 2023 •
edited
Loading

Looks like qiskit's Diagonal inherits from QuantumCircuit rather than Instruction so the conversion isn't quite as clean as I thought.

EDIT: DiagonalGate inherits from Gate so this should be doable -> https://docs.quantum.ibm.com/api/qiskit/qiskit.circuit.library.DiagonalGate

@CalMacCQ CalMacCQ added enhancement New feature or request circuit_conversion Issues and pull requests related to coverting qiskit circuits to pytket and vice versa labels Apr 5, 2024
@CalMacCQ CalMacCQ added the good first issue Good for newcomers label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
circuit_conversion Issues and pull requests related to coverting qiskit circuits to pytket and vice versa enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CalMacCQ