Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisCoCirc: Add a filtering mechanism for the nouns #187

Closed
dimkart opened this issue Nov 18, 2024 · 2 comments
Closed

DisCoCirc: Add a filtering mechanism for the nouns #187

dimkart opened this issue Nov 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dimkart
Copy link
Contributor

dimkart commented Nov 18, 2024

The set of entities corresponding to wires in a DisCoCirc diagram should be controlled in some way to keep the size of the diagram manageable and to avoid the inclusion of insignificant entities that could appear in the document. Using a simple metric such as TF-IDF might be a good first step. The metric can apply on simple noun tokens, or on dependencies derived from a dependency parser for more robust coverage.

@dimkart dimkart added the enhancement New feature or request label Nov 18, 2024
@dimkart
Copy link
Contributor Author

dimkart commented Nov 18, 2024

@AnnaNPearson suggested that the nouns that do not make the threshold shouldn't be discarded completely but it would be useful to appear in the diagram as single boxes, interacting with their context. This feature can be offered to the user as an extra option.

@dimkart
Copy link
Contributor Author

dimkart commented Dec 4, 2024

Resolved by #192, at least the filtering part. For @AnnaNPearson 's comment above there is now a separate issue opened (#194).

@dimkart dimkart closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant