Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix the release-plz fix #1120

Merged
merged 1 commit into from
May 29, 2024
Merged

ci: fix the release-plz fix #1120

merged 1 commit into from
May 29, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented May 28, 2024 •
edited
Loading

you can't create a git release without a git tag

So that was a lie. The releases are still created.

#1119 shouldn't have dropped the git_release_enable lines.

@aborgna-q aborgna-q requested a review from ss2165 May 28, 2024 15:07
@aborgna-q aborgna-q requested a review from a team as a code owner May 28, 2024 15:07
@aborgna-q aborgna-q requested review from cqc-alec and removed request for ss2165 May 29, 2024 08:43
@aborgna-q aborgna-q added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit f757cc8 May 29, 2024
15 checks passed
@aborgna-q aborgna-q deleted the ab/plz-work branch May 29, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aborgna-q @cqc-alec