Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation check needs to work with open extension sets #454

Closed
croyzor opened this issue Aug 24, 2023 · 1 comment
Closed

Validation check needs to work with open extension sets #454

croyzor opened this issue Aug 24, 2023 · 1 comment
Assignees
@croyzor

Comments

@croyzor
Copy link
Contributor

croyzor commented Aug 24, 2023

Resource inference succeeds even when not all locations on the hugr can have a concrete resource associated with them. If we succeed in this manner, a subsequent validation check should also succeed
@croyzor croyzor self-assigned this Aug 24, 2023
This was referenced Aug 22, 2023
Open
Merged
croyzor added a commit that referenced this issue Aug 25, 2023
@croyzor
feat: Extension validation can take a closure of solutions (#456)
fe5c9ec 
Fixes #454.
Return from extension inference an extra solution set, which
instantiates all of the inference variables to the empty set, meaning
metavariables which depend on them can be solved
@croyzor
Copy link
Contributor Author

croyzor commented Aug 25, 2023

#456 adds a workaround allowing extension inference to return a value which, when passed to extension validation, allows it to succeed. A new issue has been created for making a more permissive extension validation scheme: #457

@croyzor croyzor closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@croyzor croyzor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@croyzor