You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It might be slightly better in terms of future-proofing to have this op take tuples of inputs and outputs, instead of rows. My reasoning is that in the future, when we have row kinded type params, we should be able to define this op without needing compute_signature.
When we have row-kinded type params, we'll be able to use a typescheme to generate a panic op-node with a variable number of inputs/outputs. I presume that's what we've got ATM, but we won't need a binary compute_signature anymore.
In the meantime we could drop the binary compute_signature of #1024 if we took/returned tuples, but that moves away from the ideal interface (taking/returning multiple values) in order to simplify our implementation sooner. I wouldn't worry about that (?).
Suspect either I'm confused about what panic does or your confused about what row-variables will enable, so if not clear, let's talk IRL...
Originally posted by @croyzor in #1024 (review)
The text was updated successfully, but these errors were encountered: