Sync docs with vss-tools rework #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschleemilch
force-pushed
the
feature/docs-vss-tools-rework
branch
from
89c8bf0 to
f732e05
Compare
Signed-off-by: Sebastian Schleemilch <[email protected]>
sschleemilch
force-pushed
the
feature/docs-vss-tools-rework
branch
from
f732e05 to
7971e7b
Compare
|
Please review |
| [VSS-Tools](https://github.com/COVESA/vss-tools) however require that all units used are defined, | ||
| and at is also a requirement for signals in the VSS standard catalog. | ||
| [VSS-Tools](https://github.com/COVESA/vss-tools) however require that all units used are defined | ||
| and therefore is also a requirement for signals in the VSS standard catalog. |
There was a problem hiding this comment.
Reading this, I feel we should just demand a unit in VSS for it to be valid and be done with it.
Not related to this PR though
SebastianSchildt
approved these changes
Aug 20, 2024
|
Meeting 08/27: Merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and made docs consistent with vss-tools rework: COVESA/vss-tools#382