Support negative torque for combustion engine #665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring latest COVESA master into my fork
erikbosch
added
Status:Review
|
Based on previous discussions this would be considered as a major change as we change signal type, i.e. intended only for 5.0, not 4.1 No sign-offs in commits, that is why the DCO check fails. I noticed however that the guidelines does not specify that well if sign off should be in PR or commit(s). (FYI: @paulboyes ) But as I remember we have said that it should be in commits. |
|
I presume that I can add a commit with just a comment, so that the sign off is in a commit. |
|
Meeting notes:
|
Some combustion engine vehicles report a negative torque under braking conditions. This cannot be properly reflected by the current definition of engine torque as it is an unsigned integer. This change proposes modifying the combustion engine torque definition from an unsigned integre to an integer. Signed-off-by: Pierre Pierre Blais [email protected]
erikbosch
removed
the
Status:New
|
Meeting notes:
|
|
@ppb2020 - have you checked if you can update the PR/commit, or should I assist with a "workaround"? |
|
I have not been able to resolve the squashing issue as I always end up with two commits. Closing the PR. Will resubmit the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some combustion engine vehicles report a negative torque under braking conditions. This cannot be properly reflected by the current definition of engine torque as it is an unsigned integer.
This change proposes modifying the combustion engine torque definition from an unsigned integre to an integer.
Signed-off-by: Pierre Pierre Blais [email protected]