Era5 fix. Typo, and need to combine years into single file again #170
Conversation
| ).sel( | ||
| latitude=slice( | ||
| self.latitude_extent[1], self.latitude_extent[0] | ||
| ) ## This is because ERA5 has latitude in decreasing order (??) |
There was a problem hiding this comment.
What is this question here? Can’t we find out if that’s true or not and remove the “(??)”?
There was a problem hiding this comment.
I'm not really sure tbh - might have been a reason for this but I never wrote it down. Don't have too much time today to troubleshoot but was just trying to get this patched for Anupiya (new student of Callum) who couldn't get the example working
There was a problem hiding this comment.
Need to make the most of Gadi being up before it takes a 2 day holiday!!
|
The downloading? We currently don't do any automatic downloading because the Copernicus Marine client is still very unstable and undergoing work. this package currently assumes you've already done all the downloading |
|
This patch doesn't need to be perfect for now, but until it goes through the example won't work when running MOM6 |
|
@AVEllepola can install from this branch. We should merge this when properly reviewed |
I'd separated ERA5 forcing files into separate years automatically, but this probably isn't the best workflow. If someone does do an IAF run with HUGE forcing files, they should be able to split the forcing files up yearly as needed themselves. As it stands the package tried to anticipate this and split each ERA5 field into each forcing year, but this requires extra overhead and explaining unnecessary for simple runs.
In fact, it required modifications to the
data_tablefile specifying the year in the filename, so broke the reanalysis forced example! So this patch (or something like it) is necessary to keep example working