Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle logging messages by module #37

Open
aFuerst opened this issue Dec 31, 2024 · 0 comments
Open

Toggle logging messages by module #37

aFuerst opened this issue Dec 31, 2024 · 0 comments

Comments

@aFuerst
Copy link
Contributor

aFuerst commented Dec 31, 2024

We used logs to export information on worker choices for post-processing. These are used for specific papers/experiments and afterwards we are currently left with three options:

  • Delete the logging lines from the codebase (making re-production hard)
  • Create boolean configuration settings and code fence them
  • Do nothing and bloat the log files with extraneous information

A targeted way to enable these via the Logging configuration would be ideal. Log events have a target, (e.g. iluvatar_worker_library::services::resources::gpu) member corresponding to the module & file the log message was in.

Possible solution:
We could set experimental log statements like these to debug or trace and create a custom Layer that allows them to bypass the log level filter if target matches given configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant