Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDLm checks to GitHub actions #30

Open
vaitkus opened this issue Jun 29, 2023 · 3 comments
Open

Add DDLm checks to GitHub actions #30

vaitkus opened this issue Jun 29, 2023 · 3 comments

Comments

@vaitkus
Copy link
Collaborator

vaitkus commented Jun 29, 2023

Currently, GitHub actions only check the syntax of the dictionary file, but not the style or semantics as in other dictionary repositories.

However, it was mentioned in a comment of a different issue [1] that there are some changes lined up, so I am not completely sure when would be the least disruptive time to turn on the checks. One the one hand they do detected some serious internal inconsistencies, but on the other hand they do complain about some trivial things like update dates, etc.

[1] #29 (comment)

@brantonc
Copy link
Collaborator

brantonc commented Jul 1, 2023

Can GitHub Actions be selectively turned off again for the magCIF repository if it creates a hindrance to pending changes from the commission?

@vaitkus
Copy link
Collaborator Author

vaitkus commented Jul 4, 2023

Yes, in that case we could simply disable the checks. Also, the general policy towards GitHub actions in other dictionary repositories is pretty lax -- even if the checks fail (i.e. issues are detected), this does not technically prevent the PRs from being merged.

@vaitkus
Copy link
Collaborator Author

vaitkus commented Jul 18, 2023

I just realised that CIF_MAG imports CIF_MS (modulated structure) dictionary which is also currently not checked against the additional DDLm rules. We should probably fix that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants