Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly mark *_Fourier.axes_description data items as deprecated #23

Open
vaitkus opened this issue Mar 19, 2024 · 0 comments
Open

Properly mark *_Fourier.axes_description data items as deprecated #23

vaitkus opened this issue Mar 19, 2024 · 0 comments

Comments

@vaitkus
Copy link
Contributor

vaitkus commented Mar 19, 2024

The human-readable descriptions of the _atom_sites_displace_Fourier.axes_description and _atom_sites_rot_Fourier.axes_description data items states that they are deprecated:

DEPRECATED. This data name should not be used. It has been replaced
by the ATOM_SITES_AXES data names.

This deprecation should also be explicitly marked using attributes from the DEFINITION_REPLACED category. For example, for the _atom_sites_displace_Fourier.axes_description data item it could look something like:

loop_
      _definition_replaced.id
      _definition_replaced.by
         1                        '_atom_site_displace_Fourier.matrix_seq_id'
         2                        '_atom_sites_axes.matrix_seq_id'
         3                        '_atom_sites_axes.transf_description'
         4                        '_atom_sites_axes.matrix'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant