From 1dec74d309b5cacc1cc2568dcd4e7295ea68793e Mon Sep 17 00:00:00 2001 From: "J. Gonzalez" Date: Tue, 7 Nov 2023 16:27:53 -0500 Subject: [PATCH] Disable Snyk workflows Snyk is incompatible with our workflow because its GitHub actions aren't compatible with static analysis on our code, for reasons that appear to be due to licensing. Therefore, we disable it. --- .github/workflows/snyk-node.yaml | 11 --- .github/workflows/snyk-security.yml | 85 ------------------- .../workflows/snyk_static_analysis_scan.yaml | 19 ----- 3 files changed, 115 deletions(-) delete mode 100644 .github/workflows/snyk-node.yaml delete mode 100644 .github/workflows/snyk-security.yml delete mode 100644 .github/workflows/snyk_static_analysis_scan.yaml diff --git a/.github/workflows/snyk-node.yaml b/.github/workflows/snyk-node.yaml deleted file mode 100644 index f061b09..0000000 --- a/.github/workflows/snyk-node.yaml +++ /dev/null @@ -1,11 +0,0 @@ -name: Example workflow for Node using Snyk -on: push -jobs: - security: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@master - - name: Run Snyk to check for vulnerabilities - uses: snyk/actions/node@master - env: - SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} diff --git a/.github/workflows/snyk-security.yml b/.github/workflows/snyk-security.yml deleted file mode 100644 index 9de57a6..0000000 --- a/.github/workflows/snyk-security.yml +++ /dev/null @@ -1,85 +0,0 @@ -# This workflow uses actions that are not certified by GitHub. -# They are provided by a third-party and are governed by -# separate terms of service, privacy policy, and support -# documentation. - -# A sample workflow which sets up Snyk to analyze the full Snyk platform (Snyk Open Source, Snyk Code, -# Snyk Container and Snyk Infrastructure as Code) -# The setup installs the Snyk CLI - for more details on the possible commands -# check https://docs.snyk.io/snyk-cli/cli-reference -# The results of Snyk Code are then uploaded to GitHub Security Code Scanning -# -# In order to use the Snyk Action you will need to have a Snyk API token. -# More details in https://github.com/snyk/actions#getting-your-snyk-token -# or you can signup for free at https://snyk.io/login -# -# For more examples, including how to limit scans to only high-severity issues -# and fail PR checks, see https://github.com/snyk/actions/ - -name: Snyk Security - -on: - push: - branches: ["main" ] - pull_request: - branches: ["main"] - -permissions: - contents: read - -jobs: - snyk: - environment: SNYK_TOKEN - permissions: - contents: read # for actions/checkout to fetch code - security-events: write # for github/codeql-action/upload-sarif to upload SARIF results - actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Set up Snyk CLI to check for security issues - # Snyk can be used to break the build when it detects security issues. - # In this case we want to upload the SAST issues to GitHub Code Scanning - uses: snyk/actions/setup@master - - - # For Snyk Open Source you must first set up the development environment for your application's dependencies - # For example for Node - #- uses: actions/setup-node@v3 - # with: - # node-version: 16 - - env: - # This is where you will need to introduce the Snyk API token created with your Snyk account - SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} - PLEASE_SHOW: "HIIII" - - # Runs Snyk Code (SAST) analysis and uploads result into GitHub. - # Use || true to not fail the pipeline - - name: Snyk version - run: echo "${{ steps.snyk.outputs.version }} and ${{ secrets.SNYK_TOKEN }}" - - - name: Snyk Code test - run: snyk code test -d --sarif > snyk-code.sarif # || true - - # Runs Snyk Open Source (SCA) analysis and uploads result to Snyk. - - name: Snyk Open Source monitor - run: snyk monitor --all-projects - - # Runs Snyk Infrastructure as Code (IaC) analysis and uploads result to Snyk. - # Use || true to not fail the pipeline. - - name: Snyk IaC test and report - run: snyk iac test --report # || true - - # Build the docker image for testing - - name: Build a Docker image - run: docker build -t your/image-to-test . - # Runs Snyk Container (Container and SCA) analysis and uploads result to Snyk. - - name: Snyk Container monitor - run: snyk container monitor your/image-to-test --file=Dockerfile - - # Push the Snyk Code results into GitHub Code Scanning tab - - name: Upload result to GitHub Code Scanning - uses: github/codeql-action/upload-sarif@v2 - with: - sarif_file: snyk-code.sarif diff --git a/.github/workflows/snyk_static_analysis_scan.yaml b/.github/workflows/snyk_static_analysis_scan.yaml deleted file mode 100644 index 5a8d410..0000000 --- a/.github/workflows/snyk_static_analysis_scan.yaml +++ /dev/null @@ -1,19 +0,0 @@ -name: Snyk Static Analysis Scan -# This SAST (Static Application Security Testing) scan is used to scan -# our first-party code for security vulnerabilities -on: - pull_request: - branches: - - master - - develop -jobs: - Snyk_SAST_Scan: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - uses: snyk/actions/setup@master - - name: Perform Static Analysis Test - env: - SNYK_TOKEN: ${{ secrets.SNYK_API_TOKEN }} - continue-on-error: true - run: snyk code test --all-projects --strict-out-of-sync=false --detection-depth=6 --exclude=docker,Dockerfile --severity-threshold=high