Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Snyk workflows #50

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Disable Snyk workflows #50

merged 1 commit into from
Nov 13, 2023

Conversation

gonzalezjo
Copy link
Contributor

Snyk is incompatible with our workflow because its GitHub actions aren't compatible with static analysis on our code, for reasons that appear to be due to licensing. Therefore, we disable it.

Snyk is incompatible with our workflow because its GitHub actions aren't compatible with static analysis on our code, for reasons that appear to be due to licensing. Therefore, we disable it.
@gonzalezjo gonzalezjo requested a review from Noor-5 November 7, 2023 21:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6790523010

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 85.029%

Files with Coverage Reduction New Missed Lines %
src/groups/join.js 1 92.05%
src/meta/build.js 4 54.17%
Totals Coverage Status
Change from base Build 6726524152: 0.1%
Covered Lines: 22651
Relevant Lines: 25395

💛 - Coveralls

@ruiminggu
Copy link
Contributor

It's good to see that we got rid of Synk since its incompatible. It looks good to me.

@gonzalezjo gonzalezjo merged commit d7a30ca into main Nov 13, 2023
12 of 13 checks passed
@gonzalezjo gonzalezjo removed the request for review from Noor-5 November 13, 2023 18:30
@gonzalezjo gonzalezjo deleted the disable_snyk branch November 13, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants