Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change resolve button #34

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Change resolve button #34

merged 5 commits into from
Oct 12, 2023

Conversation

zhijinwuu
Copy link
Contributor

@zhijinwuu zhijinwuu commented Oct 12, 2023

Resolved #29

Flip the resolved/unresolved button when switching between the two status. Use a circle checkbox to show.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6500994785

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 84.921%

Files with Coverage Reduction New Missed Lines %
src/messaging/notifications.js 1 94.83%
Totals Coverage Status
Change from base Build 6500648192: 0.005%
Covered Lines: 22616
Relevant Lines: 25387

💛 - Coveralls

@gonzalezjo
Copy link
Contributor

LGTM

@gonzalezjo gonzalezjo merged commit 79647e6 into main Oct 12, 2023
10 of 11 checks passed
gonzalezjo pushed a commit that referenced this pull request Oct 12, 2023
* Change the UI for topic list

* flip button when unresolved

* change button to square checkbox

* change button to circle checkbox

---------

Authored-by: ruiminggu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the resolve button so that it flips when pressing it
4 participants