Add resolved status in topic list #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhijinwuu
changed the title
|
Recall that this code was taken and added to another PR. (TY!) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue #16
Building on pull request add resolved feature #19, I duplicated the new field for new topics, which is a boolean indicating whether the discussion is resolved or not. This change was in the file src/topics/create.js.
Additionally, I added a class in themes/nodebb-theme-persona/templates/partials/topics_list.tpl to display the discussion's status (resolved or unresolved) to the topic list page. I haven't adjusted the exact position/font of the display, but the general idea of showing the status is as below:
