Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments on posts are not being deleted #1

Open
sophiajwitt opened this issue Sep 7, 2023 · 0 comments · May be fixed by #4, #5, #8, #16 or #22
Open

Comments on posts are not being deleted #1

sophiajwitt opened this issue Sep 7, 2023 · 0 comments · May be fixed by #4, #5, #8, #16 or #22

Comments

@sophiajwitt
Copy link
Contributor

sophiajwitt commented Sep 7, 2023 •
edited
Loading

As an admin, when I delete a comment on a post, the interface tells me it has been deleted, however when I check to see if the comment is gone it's still there.

Here is a video representation of the bug
@adityaganesh0309 adityaganesh0309 mentioned this issue Sep 20, 2023
Open
@Adeline09 Adeline09 mentioned this issue Sep 20, 2023
Open
@Sweetsuro Sweetsuro linked a pull request Sep 20, 2023 that will close this issue
Open
This was referenced Sep 20, 2023
Open
Closed
@JadenDabreo JadenDabreo linked a pull request Sep 20, 2023 that will close this issue
Open
@melghali melghali mentioned this issue Sep 20, 2023
Open
@spydermnky spydermnky mentioned this issue Sep 20, 2023
Open
@akintayosalu akintayosalu mentioned this issue Sep 20, 2023
Open
@cylee33 cylee33 mentioned this issue Sep 20, 2023
Open
@smithlauren910 smithlauren910 mentioned this issue Sep 20, 2023
Open
@yuvanshu yuvanshu linked a pull request Sep 20, 2023 that will close this issue
Open
@MatthewLeboffe MatthewLeboffe mentioned this issue Sep 20, 2023
Open
@haok1402 haok1402 mentioned this issue Sep 20, 2023
Closed
@SerenaYaoo SerenaYaoo linked a pull request Sep 20, 2023 that will close this issue
Open
@PeterNotFound114 PeterNotFound114 mentioned this issue Sep 20, 2023
Open
@lwunder lwunder linked a pull request Sep 20, 2023 that will close this issue
Open
@BojunLi03 BojunLi03 linked a pull request Sep 20, 2023 that will close this issue
Open
hanahryu pushed a commit to hanahryu/CMU-313-fall23-sw-archaeology-recitation that referenced this issue Sep 20, 2023
fixed delete comment bug issue CMU-313#1
af4d4f7
@cccindyyyl cccindyyyl mentioned this issue Sep 20, 2023
Closed
@iimimii iimimii linked a pull request Sep 20, 2023 that will close this issue
Open
@yliang412 yliang412 linked a pull request Sep 20, 2023 that will close this issue
Open
@raunak-sood2003 raunak-sood2003 mentioned this issue Sep 20, 2023
Closed
@SenF1 SenF1 mentioned this issue Sep 20, 2023
Closed
@hanahryu hanahryu mentioned this issue Sep 20, 2023
Open
@oliviavanzandt oliviavanzandt mentioned this issue Sep 20, 2023
Open
@YuheMa702 YuheMa702 linked a pull request Sep 20, 2023 that will close this issue
Open
@aaronmarm aaronmarm linked a pull request Sep 20, 2023 that will close this issue
Open
@aandrewchung aandrewchung mentioned this issue Sep 20, 2023
Open
@monicaq21 monicaq21 mentioned this issue Sep 20, 2023
Open
@juhyep juhyep linked a pull request Sep 22, 2023 that will close this issue
Open
@AvaGivone AvaGivone mentioned this issue Sep 22, 2023
Open
@tikakumar tikakumar mentioned this issue Sep 22, 2023
Open
@nehatirumalai nehatirumalai mentioned this issue Sep 22, 2023
Open
@TBennur TBennur linked a pull request Sep 22, 2023 that will close this issue
Open
gonzalezjo added a commit to gonzalezjo/CMU-313-fall23-sw-archaeology-recitation that referenced this issue Sep 22, 2023
@gonzalezjo
Fix comment deletion
a255e1b 
Comments previously were not being deleted because after deletion in the DB, we'd return without actually committing the changes. Now, we commit the changes, and so it should actually work.

Resolves CMU-313#1
@gonzalezjo gonzalezjo linked a pull request Sep 22, 2023 that will close this issue
Open
@Icyviolet23 Icyviolet23 linked a pull request Sep 22, 2023 that will close this issue
Open
@minjooki minjooki mentioned this issue Sep 22, 2023
Closed
@arustogi arustogi mentioned this issue Sep 22, 2023
Closed
@hankxu1212 hankxu1212 linked a pull request Sep 22, 2023 that will close this issue
Open
@jonathanho168 jonathanho168 linked a pull request Sep 22, 2023 that will close this issue
Open
@ngirase10 ngirase10 mentioned this issue Sep 22, 2023
Open
@jpurista jpurista linked a pull request Sep 22, 2023 that will close this issue
Open
@kc12341 kc12341 linked a pull request Sep 22, 2023 that will close this issue
Open
@dhruva2000 dhruva2000 mentioned this issue Sep 22, 2023
Closed
@skbedi skbedi mentioned this issue Sep 22, 2023
Open
@OlegP-andrew OlegP-andrew mentioned this issue Sep 22, 2023
Open
@vanessalin0226 vanessalin0226 mentioned this issue Sep 22, 2023
Open
@Sebastian0011 Sebastian0011 mentioned this issue Sep 22, 2023
Open
@kayliny02 kayliny02 linked a pull request Sep 22, 2023 that will close this issue
Open
@ellenfang77 ellenfang77 mentioned this issue Sep 22, 2023
Open
@Noor-5 Noor-5 mentioned this issue Sep 22, 2023
Open
@connormaas-cmu connormaas-cmu linked a pull request Sep 22, 2023 that will close this issue
Open
@khuslenmisheel khuslenmisheel mentioned this issue Sep 22, 2023
Open
@TyreceDJ TyreceDJ mentioned this issue Sep 22, 2023
Open
@cwesterink cwesterink mentioned this issue Sep 22, 2023
Open
@kateyzcodes kateyzcodes mentioned this issue Sep 22, 2023
Open
@ryan-huan ryan-huan linked a pull request Sep 22, 2023 that will close this issue
Open
@joycehua joycehua linked a pull request Sep 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes deleting comments bug Sweetsuro/CMU-313-fall23-sw-archaeology-recitation
Fix comment deletion bug riybha216/CMU-313-fall23-sw-archaeology-recitation
Changes in blueprints/main.py now deleting comments correctly JadenDabreo/CMU-313-fall23-sw-archaeology-recitation
Fixed Comment Deletion yuvanshu/CMU-313-fall23-sw-archaeology-recitation
fixed 'delete-comment' bug SerenaYaoo/CMU-313-fall23-sw-archaeology-recitation
Fixed bug where photo isn't actually deleting. lwunder/CMU-313-fall23-sw-archaeology-recitation
Fixed comments not deleting bug BojunLi03/CMU-313-fall23-sw-archaeology-recitation
fixed deleting bug, so that comments are able to be deleted now iimimii/CMU-313-fall23-sw-archaeology-recitation
fix: commit changes when deleting comments yliang412/CMU-313-fall23-sw-archaeology-recitation
Updated main.py and Fix Issue #1 YuheMa702/CMU-313-fall23-sw-archaeology-recitation
1 participant
@sophiajwitt