Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbosity #187

Open
krober10nd opened this issue Feb 15, 2021 · 3 comments
Open

Verbosity #187

krober10nd opened this issue Feb 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@krober10nd
Copy link
Collaborator

  • some methods are excessively verbose (msh.clean) for example.

  • perhaps we could handle this in a more consistent way with more controls. For example introducing a verbose kwarg to all methods that is either true or false and false will silence all output while true is left for debugging and advanced use cases.

  • Often warning messages become lost in the sea of text and it’s simply messy.

@WPringle
Copy link
Collaborator

WPringle commented Feb 16, 2021

I think that's a fair comment.

Could we add a m.messages field to show what operations have been performed on it and any notes.

e.g.,

  • msh.interp() method was performed on 2030/12/12 12:00 UTC with the following input options: filename = GEBCO, CA = 1, ...
  • msh.bound_courant_number() method was performed on 2030/12/12 12:05 UTC with the following input options: dt = 2, cr_max = 1, .... Important note: boundary conditions were deleted during this step.

@krober10nd
Copy link
Collaborator Author

I really like the idea of keeping a record in the object indicating in plain English what was done.

@krober10nd krober10nd added the enhancement New feature or request label Feb 16, 2021
@CHLNDDEV
Copy link
Owner

#200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants