Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A separate ESYS-Particle xml element is needed #223

Closed
llaniewski opened this issue Sep 26, 2019 · 2 comments
Closed

A separate ESYS-Particle xml element is needed #223

llaniewski opened this issue Sep 26, 2019 · 2 comments
Assignees
Labels
bug third party Related to third party software watch out! Things to watch out for (bug/non-bug weird behavior)
Milestone

Comments

@llaniewski
Copy link
Member

Problem

Because of my lazy naming, we ended up with a <RemoteForceInterface> element which both runs the Remote Force Interface (RFI) and executes (or connects to) ESYS-Particle code. This naming doesn't make sens and has to be changed.

Proposed solution

Separate elements should be available. The <RemoteForceInterface integrator="..."> should run RFI and connect to a selected integrator. A separate <ESYSParticle> element should run the ESYS-Particle code, and there should be different elements for other DEM codes (LAMMPS in near future).

Comments

This change is not backwards compatible. Old xml files involving RemoteForceInterface would have to be changed.

@llaniewski llaniewski added bug third party Related to third party software watch out! Things to watch out for (bug/non-bug weird behavior) labels Sep 26, 2019
@llaniewski llaniewski added this to the V 6.3 milestone Sep 26, 2019
@llaniewski llaniewski self-assigned this Sep 26, 2019
@mdzik
Copy link
Member

mdzik commented Sep 26, 2019

Might be we should use xml namespace?

<DEM:ESYSParticle ...>
<DEM:LAMMPS ...>

as a rule for "similar" nodes to make it clearer
it looks like pugi could handle that, (nodename will contain ":" imho)

@llaniewski
Copy link
Member Author

Code modified by #225
Documentation in due time CFD-GO/TCLB_docs#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug third party Related to third party software watch out! Things to watch out for (bug/non-bug weird behavior)
Projects
None yet
Development

No branches or pull requests

2 participants