-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broad, sweeping improvements #37
Open
brandonsturgeon
wants to merge
35
commits into
main
Choose a base branch
from
feature/include-http-failures-in-retries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonsturgeon
added
bug
Something isn't working
enhancement
New feature or request
labels
Jun 18, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ballooned up with a few different fixes and enhancements.
Currently, it:
unsuccessful
failuresRange
header (supported in: Add Range header support gm_express_service#9) to download in chunksexpress.Send
raw string data, skipping the serialization stepexpress.Seed
which allows you to seed data before you need to send itThis will probably be the second-to-last major change before I put more time into a V2 rewrite with the lessons learned on our first run through.
Todo:
Do you want to use this?
I believe it's currently stable enough to run.
It should fix a lot of the instability and odd behavior seen from Express's main branch.
You need to:
feature/include-http-failures-in-retries
)express_domain
convar tostg.gmod.express