Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: specificity, file loading #58

Open
karindalziel opened this issue Dec 17, 2018 · 2 comments
Open

css: specificity, file loading #58

karindalziel opened this issue Dec 17, 2018 · 2 comments

Comments

@karindalziel
Copy link
Member

many css rules have things like td.classname or h1.classname. The element name shouldn't be necessary in most cases but in others it's causing specificity problems.

try to remove specificity issues, or at least identify where in core they are coming from and comment.

@techgique
Copy link
Member

We'll probably have to remove element names from selectors in core too for selectors to override like we want. May have to check with others on how their theme CSS is written too.

@karindalziel karindalziel changed the title css: check specificity css: specificity, file loading Jan 17, 2019
@karindalziel
Copy link
Member Author

In addition to other issues, I'm currently using !important to add link underlines which isn't great.

What I'd like to have happen:

  • get django set up somewhat like rails, where you can specify that multiple files get loaded into one css file in a defined order. This has an advantage of being able to set variables in one file and use them in another
  • if we do that, we'd have to override the bootstrap.min file from core so it isn't called twice (currently I'm overriding that by having it in the same location). I played around a bit with using blocks to do this, which would be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants