Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil checking, XML methods, and API v1 #229

Open
wkdewey opened this issue Jul 16, 2024 · 0 comments · Fixed by #226
Open

Nil checking, XML methods, and API v1 #229

wkdewey opened this issue Jul 16, 2024 · 0 comments · Fixed by #226
Assignees

Comments

@wkdewey
Copy link
Contributor

wkdewey commented Jul 16, 2024

I noticed, when testing the Chesnutt repo, that a number of the API v1 fields fail nil checks. This happens because XML/Nokogiri methods no longer return an empty string but nil. Some will have to be dealt with on a case by case basis, but I wonder if this can be handled in the default overrides.

@wkdewey wkdewey added this to the Habeas Release milestone Jul 16, 2024
@wkdewey wkdewey self-assigned this Jul 16, 2024
@wkdewey wkdewey linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant