Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate headings for tables #256

Open
kmcmullen opened this issue Jun 15, 2024 · 4 comments
Open

remove duplicate headings for tables #256

kmcmullen opened this issue Jun 15, 2024 · 4 comments
Assignees
@erinchambers
Labels
design design work/decisions high priority
Milestone
Correspondence gr...

Comments

@kmcmullen
Copy link
Contributor

When we have a table, the <head> of the table is currently displaying twice. See https://cdrhdev1.unl.edu/chesnutt/item/ccda.corr01888 ("Dr." and "Cr." are only supposed to appear once). We need to remove one of those.
@kmcmullen kmcmullen added bug Something is broken design design work/decisions labels Jun 15, 2024
@kmcmullen kmcmullen added this to the Correspondence grant #2 milestone Jun 15, 2024
@erinchambers
Copy link
Contributor

erinchambers commented Sep 5, 2024 •
edited
Loading

The Chesnutt XSLT has a template that overrides Datura's <head> formatting, such that it wasn't ignoring head elements that were table headers. Meanwhile, Datura has a template for table/head, so we were getting duplicates.

There are probably more elegant ways to handle this, but I wanted to be as minimally invasive as possible... I added an <xsl:when> to the custom template: if its direct parent is <table>, the custom template just doesn't add anything. I also tested to make sure it only applies to table heads, and not headings within other table cells.

@erinchambers
Copy link
Contributor

Here's the commit

@erinchambers erinchambers removed the bug Something is broken label Sep 5, 2024
@kmcmullen
Copy link
Contributor Author

That seems perfect. Thanks, @erinchambers! Should I wait for you to close this?

@erinchambers
Copy link
Contributor

Awesome! I'll have Karin review the PR and then close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erinchambers erinchambers

Labels
design design work/decisions high priority
Projects
None yet
Milestone
Correspondence grant #2
Development

No branches or pull requests
2 participants
@erinchambers @kmcmullen