Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change count thresholds to be fractions instead of integers #63

Open
kelly-sovacool opened this issue Aug 20, 2024 · 4 comments
Open

change count thresholds to be fractions instead of integers #63

kelly-sovacool opened this issue Aug 20, 2024 · 4 comments
Labels
reneeTools RepoName

Comments

@kelly-sovacool
Copy link
Member

previously, ccbrpipeliner used fractions which was more portable across groups of different sizes.

current code straight from nidap:
https://github.com/CCBR/reneeTools/blob/79e612e588083869d139dd497f480676dda280bc/R/filter.R#L247-L300

@kopardev kopardev added the reneeTools RepoName label Aug 20, 2024
@kelly-sovacool
Copy link
Member Author

@phoman14 do you have any thoughts on this?

@phoman14
Copy link
Collaborator

do you mean that if a dataframe has 14 samples then Minimum_Number_of_Samples_with_Nonzero_Counts_in_Total = 0.5 instead of Minimum_Number_of_Samples_with_Nonzero_Counts_in_Total = 7?

@kelly-sovacool
Copy link
Member Author

do you mean that if a dataframe has 14 samples then Minimum_Number_of_Samples_with_Nonzero_Counts_in_Total = 0.5 instead of Minimum_Number_of_Samples_with_Nonzero_Counts_in_Total = 7?

Yes exactly. This is @kopardev's suggestion.

@phoman14
Copy link
Collaborator

I think this is a fine way to do it.
In my head It is easier to specify the exact number but if we make the input a fraction we could always calculate the fraction upstream from the exact number.
The other consideration is the input format. We should include an error check to make sure the input is in the correct format. I could see a user not understanding the format in enter any of the following 0.5, 50% or 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reneeTools RepoName
Projects
None yet
Development

No branches or pull requests

3 participants