Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_enrichment rule takes >48 hours on test dataset #131

Open
kelly-sovacool opened this issue Apr 19, 2024 · 1 comment
Open

go_enrichment rule takes >48 hours on test dataset #131

kelly-sovacool opened this issue Apr 19, 2024 · 1 comment
Assignees
@kelly-sovacool
Labels
refactor Refactor for performance improvement or readability

Comments

@kelly-sovacool
Copy link
Member

kelly-sovacool commented Apr 19, 2024 •
edited
Loading

We should find a way to improve the speed/performance of this step.

The R Markdown has a lot of for loops. Refactoring to use tidyverse paradigms should help a lot.
@kelly-sovacool kelly-sovacool self-assigned this Apr 19, 2024
@kelly-sovacool kelly-sovacool added the refactor Refactor for performance improvement or readability label Apr 19, 2024
@kelly-sovacool kelly-sovacool changed the title go_enrichment rule takes >20 hours on test dataset go_enrichment rule takes >48 hours on test dataset Apr 26, 2024
@kelly-sovacool
Copy link
Member Author

for now let's make this rule optional

@kelly-sovacool kelly-sovacool mentioned this issue May 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelly-sovacool kelly-sovacool

Labels
refactor Refactor for performance improvement or readability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kelly-sovacool