Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEH - Fix CBA fncs not available in editor when using RECOMPILE macro #1337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

XEH - Fix CBA fncs not available in editor when using RECOMPILE macro #1337

wants to merge 1 commit into from

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented May 15, 2020 •
edited by commy2
Loading

XEH - Fix CBA fncs not available in editor when using RECOMPILE macro
(DEV Only)

@PabstMirror PabstMirror changed the title XEH - Fix CBA functions not available in editor when using RECOMPILE … XEH - Fix CBA fncs not available in editor when using RECOMPILE macro May 15, 2020
@PabstMirror PabstMirror added this to the 3.15.2 milestone May 15, 2020
commy2
commy2 reviewed May 15, 2020
View reviewed changes
addons/xeh/fnc_preInit.sqf
{
private _fncName = format ["CBA_fnc_%1", configName _x];
_fncName call BIS_fnc_recompile;
} forEach (configProperties [_x]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before you change this, can this config or the super config contain any other tokens besides classes? Looks like it according to https://community.bistudio.com/wiki/Arma_3_Functions_Library. Though we likely not make use of them.

@commy2
Copy link
Contributor

commy2 commented May 15, 2020

But this only works when setting the macro in the actual CBA header files and then building cba_main, not when editing some addon? I really don't see the point of this.

@Dystopian
Copy link
Contributor

Just tested. Works as expected, CBA functions present, ACE Arsenal works.
And at least SKIP_SCRIPT_NAME definition is ignored in missionNamespace functions.

@commy2
Copy link
Contributor

commy2 commented May 15, 2020

Why do you uncomment RECOMPILE in cba_main in the first place though?

@Dystopian
Copy link
Contributor

Because I want to patch some CBA function and if I understand correctly RECOMPILE works only on game start.

@commy2
Copy link
Contributor

commy2 commented May 15, 2020

Patch for what?

@Dystopian
Copy link
Contributor

Patch to modify function, add something, maybe fix some bug, maybe just test/debug. Usual development.

@PabstMirror
Copy link
Contributor Author

recompile is pretty much equivalent to disable_compile_cache
it does force add scriptname header stuff, but that's only a problem for ultra precise benchmark-ing

commy2
commy2 suggested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove all CfgFunctions with PREPMAIN instead.

@PabstMirror PabstMirror modified the milestones: 3.15.2, 3.16 Sep 16, 2020
@PabstMirror PabstMirror modified the milestones: 3.16, Ongoing Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.

Functions are inaccessible in Eden if RECOMPILE is defined on game start
3 participants
@PabstMirror @commy2 @Dystopian