Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 회원가입 API 유효하지 않은 요청 예외처리 추가 #775

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix: 회원가입 API 유효하지 않은 요청 예외처리 추가 #775

merged 3 commits into from
Jan 9, 2025

Conversation

win-luck
Copy link
Contributor

@win-luck win-luck commented Jan 1, 2025

🚩 관련사항

📢 전달사항

  • 기존 회원가입 API는 입학년도(즉, 학번의 앞 4자리)와 학번이 동일하지 않는 잘못된 요청을 그대로 처리하고 있었습니다. 이를 방지하고자 학번 앞 4자리와 입학년도를 매핑하여 예외처리를 추가하였습니다.

📸 스크린샷

📃 진행사항

  • 예외처리 추가

⚙️ 기타사항

sanggae4133 and others added 3 commits November 21, 2024 19:03
@sanggae4133
hotfix: dev to qa (CAUCSE#759)
26fa68d 
### 🚩 관련사항

### 📢 전달사항
User Academic Record Log의 첨부 이미지 join table의 unique 제약 조건 삭제(한개의 신청서에 대한
여러 로그 허용을 위함)

### 📸 스크린샷


### 📃 진행사항

### ⚙️ 기타사항
- Hotfix

개발기간: 10분
@sanggae4133
hotfix: qa to main (CAUCSE#760)
e3523c1 
### 🚩 관련사항

### 📢 전달사항
User Academic Record Log의 첨부 이미지 join table의 unique 제약 조건 삭제(한개의 신청서에 대한
여러 로그 허용을 위함)

### 📸 스크린샷


### 📃 진행사항

### ⚙️ 기타사항
- Hotfix

개발기간: 10분
@win-luck
[fix] 회원가입 API 학번 및 가입일자 예외처리 추가 (CAUCSE#774)
c9e4744
@win-luck win-luck added the bug bug(버그) label Jan 1, 2025
@win-luck win-luck self-assigned this Jan 1, 2025
acidify04
acidify04 approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@acidify04 acidify04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인하였습니다. 고생하셨습니다!

@win-luck win-luck linked an issue Jan 2, 2025 that may be closed by this pull request
fix: 회원가입 API 유효하지 않은 요청 예외처리 추가 #774
Open
2 tasks
sanggae4133
sanggae4133 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@sanggae4133 sanggae4133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

givemethatsewon
givemethatsewon approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@givemethatsewon givemethatsewon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생각도 못했는데 좋은 예외처리인 것 같습니다. 고생하셨습니다!

@sanggae4133 sanggae4133 merged commit b98fb2a into CAUCSE:dev Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acidify04 acidify04 acidify04 approved these changes

@givemethatsewon givemethatsewon givemethatsewon approved these changes

@sanggae4133 sanggae4133 sanggae4133 approved these changes

@zestbear zestbear Awaiting requested review from zestbear

@pstar987 pstar987 Awaiting requested review from pstar987

@realisshomyang realisshomyang Awaiting requested review from realisshomyang

@OH-GITAEK OH-GITAEK Awaiting requested review from OH-GITAEK

Assignees

@win-luck win-luck

Labels
bug bug(버그)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: 회원가입 API 유효하지 않은 요청 예외처리 추가
4 participants
@win-luck @sanggae4133 @givemethatsewon @acidify04