Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync items per page to filter change #386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sync items per page to filter change #386

wants to merge 1 commit into from

Conversation

JiaXinEu
Copy link
Contributor

Summary:

Fixes #366

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Change page size of paginator when filter is changed

Proposed Commit Message:

Modify responsiveness of filters to screen size change

When the Items per page count changed, the UI takes some time to 
adjust accordingly. We should make the UI sync right after the change.

Let's update the page size of paginator.

Checklist:
  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lag between filter change and UI sync
1 participant
@JiaXinEu