-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass logging in if viewing public repos only #236
Comments
Good suggestion. Perhaps prompt for login only if the user requests to view a private repo, or perform some action that requires authentication (e.g., a write operation) |
I'm under the impression we need the github login to call github API Would be good to prompt login if we exceed the rate without github login |
Good point @gycgabriel |
@gycgabriel @damithc I have attempted to bypass logging in when viewing a public repo, but unable to fetch issues from GraphQL API endpoint. It looks like Github does not allow access to GraphQL API from users not logged in. From Github GraphQL docs, it does look like one has to authenticate before using the GraphQL API endpoints. For reference, a REST endpoint not requiring Github login (with rate limit 60/hr) looks something like this: I am thinking of the following possible solutions, but I am not sure how feasible they are:
I would love to hear what you would suggest, or if I have missed out anything important! |
When the user login, what level of access is requested from the user? If it is read access to public repos, it might be more acceptable than asking for write access to private repos. |
Currently, logging in to view public repos requests for read & write access to user's public repos (scope name With bypass logging in, the app does not ask for any read or write access from user. That is, the user is browsing the app as a public, not logged in, user. |
I'm not sure if switching between REST and GQL is worth the benefit of 60 API calls. |
@damithc In that case, to improve user experience for first time user, I think what we can do is to simplify the login process? I can imagine the use case as follows:
As of now, the process is rather complicated because our URL does not indicate the repo one is viewing, and our app does not redirect to the intended landing page upon logging in, so the process is currently as follows:
This enhancement still requires the user to login to Github, but I believe it should simplify the process and improve user experience? |
@nknguyenhc You are right, that should be the workflow. But it is not strictly about bypassing the login, so best posted as a separate issue. |
Is your feature request related to a problem? Please describe.
The user has to login to WATcher regardless of whether they are viewing public repos only or including private repos. If the user is viewing public repos only, it does not make sense to require them to log in.
Furthermore, viewing any repo (by pasting the link directly to the browser) requires logging in regardless of whether the repo is public or private.
Describe the solution you'd like
Skip the login if the user only views public repo.
If the user visits the link to directly view a repo, the user should be able to view the repo without being redirected to the login page, if the repo is public.
Describe alternatives you've considered
NIL
Additional context
NIL
The text was updated successfully, but these errors were encountered: