-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github manual edit warning message disappears after editing/submitting in tester response phase #1021
Comments
I am unsure about the second part of the message here: the tester response phase should be the last phase in PE that students are involved in, so I don't think it is possible for testers to respond during the next phase? It seems to me that the second sentence of the message here is either outdated (inherited from the dev-response phase) or should be removed. |
Good point. These issues are created by a script after the dev response phase has ended but before the tester response phase officially begun (there is a gap in between). Hence, 'next' refers to the tester response phase. |
Then in this case, will it be better to keep only the first part of the warning? ie after editing/submitting, instead of having the first line completely disappear (which is its current behaviour), it will be replaced with its first part. Before editing/submitting:
after editing/submitting:
|
We need to keep this string exactly as it is, because the same string is referenced by the issue processing script that runs between phases. If the string needs rephrasing, it needs to be done on both CATcher and script side at the same time -- but that can be a separate issue as the bug reported here is about the disappearance of the string only. |
Noted! Then I shall stick to the original problem of not removing the warning. Thanks for the clarification! |
Describe the bug
During the tester response phase, the text of the team/tester response in the issue comment on github will contain a warning message at the start. An example:
After the tester submits the response, the warning message will disappear. For example:
The warning should remain in the GitHub comments to warn testers against editing directly their response on GitHub directly.
The text was updated successfully, but these errors were encountered: