New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement execution modification with PATCH #86

Open

glatard opened this issue Feb 17, 2018 · 1 comment

Assignees

Labels

bug

Milestone

Contributor

glatard commented Feb 17, 2018 •

edited

Loading

Execution modification in /executions/<executionId> should be done with PATCH instead of PUT.

PATCH is supported in OpenAPI 3.0: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#path-item-object

Discussed during meeting on 2018-02-14.

The text was updated successfully, but these errors were encountered:

glatard added the bug label

louis-ver mentioned this issue

PUT /executions/{executionIdentifier} louis-ver/CARMIN#36

Merged

axlbonnet added this to the v0.4 milestone

axlbonnet self-assigned this

axlbonnet mentioned this issue

Various small changes #109

Merged

Contributor

axlbonnet commented Nov 22, 2019

I did this using the "JSON Patch" format (RFC 6902) instead of "JSON Merge Patch" (rfc 7396) because :

JSON Patch requires to introduce a generic json schema to describe all the changes possible on any object. This is easy in OpenAPI and it will be reusable for any PATCH method we would like to use.
JSON Merge Patch uses the same json schema of the object that needs change, but then the constraints are not the same, especially the required properties that could be absent, and I did not find a way to do that whith OpenAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment