Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that listPipelines can be called without authentication #75

Open
glatard opened this issue Nov 8, 2017 · 1 comment
Open
Assignees
Milestone

Comments

@glatard
Copy link
Contributor

glatard commented Nov 8, 2017

So that platforms can advertise their pipelines openly.

  • The platform may not return the same list if the method is authenticated or not.
  • The canExecute boolean can be customized based on the rights of the (non-)authenticated user.
  • Platform may return an empty list if it doesn't want to advertise its pipelines.

Agreed during meeting.

@glatard glatard changed the title Remove authentication on listPipelines Make sure that listPipelines can be called without authentication Nov 8, 2017
@axlbonnet axlbonnet added this to the v0.4 milestone Jul 22, 2019
@axlbonnet axlbonnet self-assigned this Jul 22, 2019
@axlbonnet
Copy link
Contributor

I made that change but I'm not sure about the value of canExecute when listPipelines is used anonymously. An anonymous user cannot used the initExecution so what would that mean is a pipeline is described to be executable to an anonymous user ? That's why I wrote the canExecute must be false in my PR, as it is clear and logic.

An other solution would be to declare that a canExecute=true pipeline returned to an anonymous mean that it's a public pipeline that is accessible after registration. I would be OK for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants