Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

Allow overriding DOCKER_HUB_REPO #9

Closed
wants to merge 2 commits into from

Conversation

lxylxy123456
Copy link

Allow the user to change DOCKER_HUB_REPO by --docker-hub-repo instead of modifying something like ~/.local/lib/python3.?/site-packages/bugswarm/common/credentials.py
Close #7

Copy link
Member

@dtomassi dtomassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change. Is this something we want?

If so, we would then probably have to support the change of having it look at a different (local) database with the show command.

@lxylxy123456
Copy link
Author

I think we need it when we need to use an experimental repo or the cached repo (bugswarm/cached-images). Currently the only workaround I know is #7, but I hope this can be a better way.

@dtomassi
Copy link
Member

I think we need it when we need to use an experimental repo or the cached repo (bugswarm/cached-images). Currently the only workaround I know is #7, but I hope this can be a better way.

What do you mean an experimental repo?

If you are doing some testing, you do not have to use the client. You can use Docker commands.

@lxylxy123456
Copy link
Author

I think we need it when we need to use an experimental repo or the cached repo (bugswarm/cached-images). Currently the only workaround I know is #7, but I hope this can be a better way.

What do you mean an experimental repo?

Something like https://hub.docker.com/repository/docker/lxylxy123456/bugswarm-repo , which was created when I was running the bugswarm pipeline.

If you are doing some testing, you do not have to use the client. You can use Docker commands.

Just to clarify, are the following two commands equivalent?

$ bugswarm run --image-tag apache-commons-lang-159112598 --docker-hub-repo bugswarm/cached-images
$ docker run --rm -it bugswarm/cached-images:apache-commons-lang-159112598 

@dtomassi
Copy link
Member

I think we need it when we need to use an experimental repo or the cached repo (bugswarm/cached-images). Currently the only workaround I know is #7, but I hope this can be a better way.

What do you mean an experimental repo?

Something like https://hub.docker.com/repository/docker/lxylxy123456/bugswarm-repo , which was created when I was running the bugswarm pipeline.

If you are doing some testing, you do not have to use the client. You can use Docker commands.

Just to clarify, are the following two commands equivalent?

$ bugswarm run --image-tag apache-commons-lang-159112598 --docker-hub-repo bugswarm/cached-images
$ docker run --rm -it bugswarm/cached-images:apache-commons-lang-159112598 

Yes those commands should be equivalent.

@lxylxy123456
Copy link
Author

lxylxy123456 commented Nov 16, 2020

Closing this pr because there is a workaround.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to switch repo?
2 participants